Skip to content

[beta] Backport renaming of lints #87962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Conversation

flip1995
Copy link
Member

Backport renaming of 2 lints that were "wrongly" named. This is so that we don't have to go through the lint renaming process, if those lints would hit stable like this.

flip1995 and others added 3 commits July 29, 2021 13:28
self_named_constructor -> self_named_constructors
append_instead_of_extend -> extend_with_drain
[beta] Backport: Rename two lints to comply with our lint naming convention

self_named_constructor -> self_named_constructors
append_instead_of_extend -> extend_with_drain

changelog: none

r? `@ghost`
@rust-highfive
Copy link
Contributor

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 12, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Aug 12, 2021

📌 Commit c89c257 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2021
@bors
Copy link
Collaborator

bors commented Aug 12, 2021

⌛ Testing commit c89c257 with merge 3c5e68d...

@bors
Copy link
Collaborator

bors commented Aug 12, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 3c5e68d to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 12, 2021
@bors bors merged commit 3c5e68d into rust-lang:beta Aug 12, 2021
@rustbot rustbot added this to the 1.55.0 milestone Aug 12, 2021
@flip1995 flip1995 deleted the clippy_backport branch August 12, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants