Skip to content

add #[inline] to Path comparison fast path #88422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

the8472
Copy link
Member

@the8472 the8472 commented Aug 28, 2021

Let's see if this fixes the regression noted in #86898 (comment)

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 28, 2021
@the8472
Copy link
Member Author

the8472 commented Aug 28, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 28, 2021
@bors
Copy link
Collaborator

bors commented Aug 28, 2021

⌛ Trying commit 3547a87 with merge 6bff2292666323be51b1d609b0c514b318d0eb39...

@bors
Copy link
Collaborator

bors commented Aug 28, 2021

☀️ Try build successful - checks-actions
Build commit: 6bff2292666323be51b1d609b0c514b318d0eb39 (6bff2292666323be51b1d609b0c514b318d0eb39)

@rust-timer
Copy link
Collaborator

Queued 6bff2292666323be51b1d609b0c514b318d0eb39 with parent 2031fd6, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (6bff2292666323be51b1d609b0c514b318d0eb39): comparison url.

Summary: This change led to small relevant mixed results 🤷 in compiler performance.

  • Small improvement in instruction counts (up to -0.2% on incr-patched: println builds of ripgrep)
  • Small regression in instruction counts (up to 0.3% on full builds of webrender)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@the8472
Copy link
Member Author

the8472 commented Aug 28, 2021

Doesn't fix the -doc regressions.

@the8472 the8472 closed this Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-perf Status: Waiting on a perf run to be completed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants