Revert path cmp optimizations

[the8472]

Check if reverting #86898 undoes the regression since I can't repro it locally

[rust-highfive]

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

[the8472]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit fedc776c36acab039e0f7039937b5c32d05c8554 with merge 40292e9b178342a1288597ffd559bb6a9eb9bb3c...

[bors]

☀️ Try build successful - checks-actions
Build commit: 40292e9b178342a1288597ffd559bb6a9eb9bb3c (40292e9b178342a1288597ffd559bb6a9eb9bb3c)

[rust-timer]

Queued 40292e9b178342a1288597ffd559bb6a9eb9bb3c with parent 42a2a53, future comparison URL.

[rust-timer]

Finished benchmarking try commit (40292e9b178342a1288597ffd559bb6a9eb9bb3c): comparison url.

Summary: ERROR categorizing benchmark run!

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

[the8472]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[the8472]

@bors try

[bors]

⌛ Trying commit fedc776c36acab039e0f7039937b5c32d05c8554 with merge 9c90b7f5fdd75c6d642824b981a6bfd1f3be9526...

[bors]

☀️ Try build successful - checks-actions
Build commit: 9c90b7f5fdd75c6d642824b981a6bfd1f3be9526 (9c90b7f5fdd75c6d642824b981a6bfd1f3be9526)

[rust-timer]

Queued 9c90b7f5fdd75c6d642824b981a6bfd1f3be9526 with parent 5eacec9, future comparison URL.

[rust-timer]

Finished benchmarking try commit (9c90b7f5fdd75c6d642824b981a6bfd1f3be9526): comparison url.

Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.

• Moderate improvement in instruction counts (up to -1.1% on incr-patched: println builds of ripgrep)
• Small regression in instruction counts (up to 0.4% on full builds of ctfe-stress-4)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[the8472]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 2faa2ce with merge e12fb3e89f76af4aafbe81b6500bf72424310788...

[bors]

☀️ Try build successful - checks-actions
Build commit: e12fb3e89f76af4aafbe81b6500bf72424310788 (e12fb3e89f76af4aafbe81b6500bf72424310788)

[rust-timer]

Queued e12fb3e89f76af4aafbe81b6500bf72424310788 with parent 59ce765, future comparison URL.

[rust-timer]

Finished benchmarking try commit (e12fb3e89f76af4aafbe81b6500bf72424310788): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

[the8472]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 973ff717ada5ebd55bf404c41dd3b985d6b6f22d with merge 9bb7d99f1e59d5596318d2be25232e97daf26778...

[bors]

💔 Test failed - checks-actions

[the8472]

@bors try

[bors]

⌛ Trying commit f8a284e with merge 5f3d903d50eebe049b1b5f5b6a10fea300365185...

[bors]

☀️ Try build successful - checks-actions
Build commit: 5f3d903d50eebe049b1b5f5b6a10fea300365185 (5f3d903d50eebe049b1b5f5b6a10fea300365185)

[rust-timer]

Queued 5f3d903d50eebe049b1b5f5b6a10fea300365185 with parent daa4dc9, future comparison URL.

[rust-timer]

Finished benchmarking try commit (5f3d903d50eebe049b1b5f5b6a10fea300365185): comparison url.

Summary: This change led to small relevant mixed results 🤷 in compiler performance.

• Small improvement in instruction counts (up to -0.4% on incr-patched: add vec item builds of deep-vector)
• Small regression in instruction counts (up to 0.5% on incr-patched: add static arr item builds of coercions)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression