Add a from_str function. #8988
Closed
Add a from_str function. #8988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there an associated bug for this? I thought we were normally wary about adding new things to the prelude. |
|
@alexcrichton no, but it's a long-standing complaint that I don't feel strongly about this PR. |
|
Agree that important changes like additions to the prelude should have issues backing them, but I'm +1 on this change since parsing strings is common and currently really ugly. |
bors
added a commit
that referenced
this pull request
Sep 8, 2013
It just calls out to the associated function on the trait.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 16, 2022
… r=flip1995 Test metadata collection in Bors CI workflow This PR adds a new check to bors CI workflows, which ensures that the metadata collection success, when it's run as part of the `deploy` script. I've only added it to bors workflows, as the runtime will be high while it'll also succeed most of the time. This is a preparation for rust-lang/rust-clippy#8947. --- changelog: none r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just calls out to the associated function on the trait.