Incremental std::rand improvements #9362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| self.gen_uint_range(1u, n + 1u) == 1u | ||
| /// Return a random vector of the specified length. This defers to | ||
| /// the `rand_vec` implementation of the requested type, and, as |
|
Review addressed. |
Also, documentation & general clean-up: - remove `gen_char_from`: better served by `sample` or `choose`. - `gen_bytes` generalised to `gen_vec`. - `gen_int_range`/`gen_uint_range` merged into `gen_integer_range` and made to be properly uniformly distributed. Fixes rust-lang#8644. Minor adjustments to other functions.
This has to leave rust_gen_seed and rng_gen_seed around since they're used to initialise the std::rand RNGs.
bors
added a commit
that referenced
this pull request
Sep 22, 2013
First steps on toward a shiny new `std::rand`, this does a variety of relatively clean-up tasks, like: - moving `std/rand.rs` to `std/rand/mod.rs` in preparation for (e.g.) splitting the large chunk that is the `Isaac` implementation into a separate file later. - removing the now unused RNG code in the old rt (500 lines gone just like that!) - merging Rng and RngUtil via default methods - examples in the documentation for almost all methods. And other things mentioned in the commit messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First steps on toward a shiny new
std::rand, this does a variety of relatively clean-up tasks, like:std/rand.rstostd/rand/mod.rsin preparation for (e.g.) splitting the large chunk that is theIsaacimplementation into a separate file later.And other things mentioned in the commit messages.