Skip to content

[test] Enable sha2-asm feature #93994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

pierwill
Copy link
Member

@pierwill pierwill commented Feb 14, 2022

Extends #93863. See #93973.

This removes the `cpuid-bool` dependency, which is deprecated,
while adding `crypto-common` as a new dependency.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 14, 2022
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2022
@pierwill
Copy link
Member Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2022
@pierwill
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 14, 2022
@bors
Copy link
Collaborator

bors commented Feb 14, 2022

⌛ Trying commit 8b2a00a with merge b3a300610235a24445d5a0ba7314673205130e46...

@klensy
Copy link
Contributor

klensy commented Feb 14, 2022

This perf run will show deps bump + feature difference, not sha2-asm feature difference

@pierwill
Copy link
Member Author

This perf run will show deps bump + feature difference, not sha2-asm feature difference

Ah, yes—thanks. 😇 Info could still be useful, but we'll want to do another run.

@pierwill
Copy link
Member Author

(@Mark-Simulacrum Is there a way to cancel an in-progress perf run?)

@bors
Copy link
Collaborator

bors commented Feb 14, 2022

☀️ Try build successful - checks-actions
Build commit: b3a300610235a24445d5a0ba7314673205130e46 (b3a300610235a24445d5a0ba7314673205130e46)

@rust-timer
Copy link
Collaborator

Queued b3a300610235a24445d5a0ba7314673205130e46 with parent b321742, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b3a300610235a24445d5a0ba7314673205130e46): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 15, 2022
@pierwill pierwill closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants