improve C ABI #9517
Merged
improve C ABI #9517
+206
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cast: bool, | ||
| ty: Type | ||
| pub struct ArgType { | ||
| /// Direct - Pass the argument directly using the normal converted |
There was a problem hiding this comment.
Would this documentation be better attached to the enum variant definitions?
|
Someone familiar with this code should take a look (@nikomatsakis? @Aatch?) |
|
Hm, this looks like some good code. We really need somebody to review. |
|
I'll take a look today. |
|
Argh, I remember now that I reviewed about 80% of this patch before! The code looks quite good to me, I'd give it r+ but for the merge conflicts. @crabtw any chance you can rebase it? |
I borrow some ideas from clang's ABIInfo.h and TargetInfo.cpp. LLVMType is replaced with ArgType, which is similar to clang's ABIArgInfo, and I also merge attrs of FnType into it. Now ABI implementation doesn't need to insert hidden return pointer to arg_tys of FnType. Instead it is handled in foreign.rs. This change also fixes LLVM assertion failure when compiling MIPS target.
|
I rebased it. |
bors
added a commit
that referenced
this pull request
Oct 11, 2013
I borrow some ideas from clang's ABIInfo.h and TargetInfo.cpp. LLVMType is replaced with ArgType, which is similar to clang's ABIArgInfo, and I also merge attrs of FnType into it. Now ABI implementation doesn't need to insert hidden return pointer to arg_tys of FnType. Instead it is handled in foreign.rs. This change also fixes LLVM assertion failure when compiling MIPS target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I borrow some ideas from clang's ABIInfo.h and TargetInfo.cpp.
LLVMType is replaced with ArgType, which is similar to clang's ABIArgInfo,
and I also merge attrs of FnType into it.
Now ABI implementation doesn't need to insert hidden return pointer
to arg_tys of FnType. Instead it is handled in foreign.rs.
This change also fixes LLVM assertion failure when compiling MIPS target.