rustdoc: Strip methods correctly based on privacy #9941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beforehand the id of a method was the id of the 'self' argument, but this is not the id which privacy was using (the id of the ast::method) struct, so by moving the ids over to the privacy-target ones the methods are now stripped correctly.
bors
added a commit
that referenced
this pull request
Oct 19, 2013
Beforehand the id of a method was the id of the 'self' argument, but this is not the id which privacy was using (the id of the ast::method) struct, so by moving the ids over to the privacy-target ones the methods are now stripped correctly.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 1, 2022
…nishearth Fix remark for `rfcs/0001-syntax-tree-patterns.md` https://github.com/rust-lang/rust-clippy/actions/runs/3542472739/jobs/5948006255#step:6:37 Removes the unused definitions, for the line length I disabled the lint for now as I gather it's going to be moved into the book in the future r? `@Manishearth` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beforehand the id of a method was the id of the 'self' argument, but this is not
the id which privacy was using (the id of the ast::method) struct, so by moving
the ids over to the privacy-target ones the methods are now stripped correctly.