Allow formatting the demangled symbol name without the trailing hash. #5
+59
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset allows for formatting the symbol name without the trailing hash. The hash is useful for Rust's linking situation, but not particularly useful to humans, and possibly harmful in cases where we want to use function names for aggregation (like crash reporting). Since the existing code is just using the `Display` trait for string conversion, I made it support the "alternate" format modifier. I don't know if there's a more sensible way to handle this. I could instead implement a separate method on the type and have the `Display` implementation call that, if you prefer.
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset allows for formatting the symbol name without the trailing
hash. The hash is useful for Rust's linking situation, but not particularly
useful to humans, and possibly harmful in cases where we want to use
function names for aggregation (like crash reporting).
Since the existing code is just using the
Displaytrait for string conversion,I made it support the "alternate" format modifier. I don't know if there's
a more sensible way to handle this. I could instead implement a separate
method on the type and have the
Displayimplementation call that, ifyou prefer.