Skip to content

native-c: add some missing statics #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

native-c: add some missing statics #76

merged 1 commit into from
Dec 3, 2024

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Dec 3, 2024

I should have added them in the previous PR but forgot

Mark-Simulacrum
Mark-Simulacrum approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test with nm or so on the exposed symbols?

@arielb1
Copy link
Contributor Author

arielb1 commented Dec 3, 2024 •
edited
Loading

Should we have a test with nm or so on the exposed symbols?

I don't think it's worth it. No C project I know of does this test and I don't see how this one is different.

@Mark-Simulacrum Mark-Simulacrum merged commit 2cdc89e into rust-lang:main Dec 3, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Jun 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielb1 @Mark-Simulacrum