Skip to content

Commit 47893ba

Browse files
authored
Add reference PRs for r? and r+ comments (#928)
1 parent 97eebb9 commit 47893ba

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/getting-started.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ automatically assign a reviewer to the PR. The reviewer is the person that will
383383
approve the PR to be tested and merged. If you want a specific reviewer (e.g. a
384384
team member you've been working with), you can specifically request them by
385385
writing `r? @user` (e.g. `r? @eddyb`) in either the original post or a followup
386-
comment.
386+
comment (you can see [this comment][r?] for example).
387387

388388
Please note that the reviewers are humans, who for the most part work on `rustc`
389389
in their free time. This means that they can take some time to respond and review
@@ -399,15 +399,18 @@ The reviewer may request some changes using the GitHub code review interface.
399399
They may also request special procedures (such as a [crater] run; [see
400400
below][break]) for some PRs.
401401

402+
[r?]: https://github.com/rust-lang/rust/pull/78133#issuecomment-712692371
402403
[#t-release/triage]: https://rust-lang.zulipchat.com/#narrow/stream/242269-t-release.2Ftriage
403404
[break]: #breaking-changes
404405

405406
When the PR is ready to be merged, the reviewer will issue a command to
406407
`@bors`, the CI bot. Usually, this is `@bors r+` or `@bors r=user` to approve
407-
a PR (there are few other commands, but they are less relevant here). This puts
408-
the PR in [bors's queue][bors] to be tested and merged. Be patient; this can take a
409-
while and the queue can sometimes be long. PRs are never merged by hand.
408+
a PR (there are few other commands, but they are less relevant here).
409+
You can see [this comment][r+] for example. This puts the PR in [bors's queue][bors]
410+
to be tested and merged. Be patient; this can take a while and the queue can
411+
sometimes be long. PRs are never merged by hand.
410412

413+
[r+]: https://github.com/rust-lang/rust/pull/78133#issuecomment-712726339
411414
[bors]: https://bors.rust-lang.org/queue/rust
412415

413416
### Bug Fixes or "Normal" code changes

0 commit comments

Comments
 (0)