Add reference PRs for r? and r+ comments
#928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to add some more changes, one sec. |
JohnTitor
force-pushed
the
example-comment
branch
from
eba3392 to
1b0372b
Compare
JohnTitor
changed the title
r? [at]someoner? and r+ comments
|
Add a reference for |
jyn514
added
the
S-waiting-on-review
jyn514
approved these changes
Oct 21, 2020
jyn514
added
S-waiting-on-author
JohnTitor
force-pushed
the
example-comment
branch
from
1b0372b to
03ad471
Compare
|
Rebased! |
jyn514
added a commit
to jyn514/rustc-dev-guide
that referenced
this pull request
Oct 21, 2020
Example usage: ``` $ ./check-in.sh usage: ./check-in.sh <since> <number-of-prs-merged> $ ./check-in.sh 2020-09-03 72 Authors: - **@1c3t3a** - **@arora-aman** ... snip ... Changes: - Replace links to `buildbot2.r-l.o` with `bors.r-l.o` [rust-lang#929](rust-lang#929) - Add reference PRs for `r?` and `r+` comments [rust-lang#928](rust-lang#928) ... snip ... Changes in progress: ```
jyn514
added a commit
to jyn514/rustc-dev-guide
that referenced
this pull request
Oct 21, 2020
Example usage: ``` $ ./check-in.sh usage: ./check-in.sh <since> <number-of-prs-merged> $ ./check-in.sh 2020-09-03 72 Authors: - **@1c3t3a** - **@arora-aman** ... snip ... Changes: - Replace links to `buildbot2.r-l.o` with `bors.r-l.o` [rust-lang#929](rust-lang#929) - Add reference PRs for `r?` and `r+` comments [rust-lang#928](rust-lang#928) ... snip ... Changes in progress: ```
jyn514
added a commit
to jyn514/rustc-dev-guide
that referenced
this pull request
Oct 21, 2020
Example usage: ``` $ ./check-in.sh usage: ./check-in.sh <since> <number-of-prs-merged> $ ./check-in.sh 2020-09-03 usage: ./check-in.sh <since> <number-of-prs-merged> help: you can find the number of PRs merged at https://github.com/rust-lang/rustc-dev-guide/pulls?q=is%3Apr+is%3Aclosed+updated%3A%3E2020-09-03 $ ./check-in.sh 2020-09-03 72 Authors: - **@1c3t3a** - **@arora-aman** ... snip ... Changes: - Replace links to `buildbot2.r-l.o` with `bors.r-l.o` [rust-lang#929](rust-lang#929) - Add reference PRs for `r?` and `r+` comments [rust-lang#928](rust-lang#928) ... snip ... Changes in progress: ```
jyn514
added a commit
that referenced
this pull request
Oct 22, 2020
Example usage: ``` $ ./check-in.sh usage: ./check-in.sh <since> <number-of-prs-merged> $ ./check-in.sh 2020-09-03 usage: ./check-in.sh <since> <number-of-prs-merged> help: you can find the number of PRs merged at https://github.com/rust-lang/rustc-dev-guide/pulls?q=is%3Apr+is%3Aclosed+updated%3A%3E2020-09-03 $ ./check-in.sh 2020-09-03 72 Authors: - **@1c3t3a** - **@arora-aman** ... snip ... Changes: - Replace links to `buildbot2.r-l.o` with `bors.r-l.o` [#929](#929) - Add reference PRs for `r?` and `r+` comments [#928](#928) ... snip ... Changes in progress: ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this would also help new contributors understand how the comment works.