Skip to content

Fix mask -> tag terminology #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2019
Merged

Fix mask -> tag terminology #287

merged 1 commit into from
Mar 15, 2019

Conversation

varkor
Copy link
Member

@varkor varkor commented Mar 14, 2019

Addresses #282 (comment).

@varkor varkor mentioned this pull request Mar 14, 2019
Merged
mark-i-m
mark-i-m approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @varkor

@mark-i-m
Copy link
Member

Hmm... it looks like a bunch of links have broken overnight... I will look into it this weekend.

@mark-i-m
Copy link
Member

@scalexm Do you know why all of the chalk links broke?

@Havvy
Copy link

Havvy commented Mar 14, 2019

If I had to guess, it's because chalk got moved out of the nursery into @rust-lang/chalk.

It looks like that project should have been under a Pin<&'links>.

@mark-i-m
Copy link
Member

I opened #288 to fix the links, but I'm pretty confident that this fix is ok without travis :P

@mark-i-m mark-i-m merged commit 960ddd6 into master Mar 15, 2019
@mark-i-m mark-i-m deleted the kinds-mask-tag branch April 1, 2019 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-i-m mark-i-m mark-i-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varkor @mark-i-m @Havvy