Skip to content

Document how to get the type of an expression using rustc_interface #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2020

Conversation

georgewfraser
Copy link
Contributor

@georgewfraser georgewfraser commented Mar 28, 2020

I am learning rustc_interface, and I am trying to improve the docs as I go. I am eager for feedback if there's a better way to do what I am documenting here. My first PR added a "Hello world" working example for rustc_interface.

This PR creates a new page, which will document how to do various common tasks with rustc_interface. It's less of a reference and more of a howto. The rustc_interface API surface is very large and so it's quite hard to get started---this page is designed to remedy that.

This page will have multiple examples, but as a place to start, I am showing how to get the type of an expression.

@mark-i-m FYI

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I would just change the title as suggested below.

r? @Zoxc

@mark-i-m
Copy link
Member

Also, could you rebase on top of master please? (it contains a bunch of link fixes)

@mark-i-m
Copy link
Member

mark-i-m commented Apr 1, 2020

It looks like you forget the SUMMARY.md. r=me with that fixed.

Thanks again for documenting this!

Co-Authored-By: Who? Me?! <[email protected]>
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @georgewfraser!

@mark-i-m mark-i-m merged commit 8a1879a into rust-lang:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants