Skip to content

Update docs to match the new x.py defaults #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jul 28, 2020

⚠️ This should not be merged until rust-lang/rust#73964 lands. ⚠️

  • Update most pages to use build/test instead of build --stage 1
  • Update pages to use build --stage 2 instead of build
  • Remove debuginfo from the example config.toml, since the defaults now match the recommended value.

I probably missed some build without --stage and some wording, but I figure the leftovers can be fixed in a follow-up PR.

@JohnTitor JohnTitor added the S-blocked Status: this PR is blocked waiting for something label Jul 28, 2020
@JohnTitor
Copy link
Member

I think https://rustc-dev-guide.rust-lang.org/building/bootstrapping.html also needs to update, e.g. stage 1 description, but we can follow-up later.

@jyn514
Copy link
Member Author

jyn514 commented Jul 28, 2020

rust-lang/rust#73964 was merged.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JohnTitor JohnTitor removed the S-blocked Status: this PR is blocked waiting for something label Jul 28, 2020
@JohnTitor JohnTitor merged commit eeca375 into rust-lang:master Jul 28, 2020
@jyn514 jyn514 deleted the defaults branch July 28, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants