Skip to content

Commit b0fa2b9

Browse files
authored
Merge pull request #1474 from nnethercote/compare-page-tweaks
Compare page tweaks
2 parents 4bb2c1e + b0cc4a2 commit b0fa2b9

File tree

1 file changed

+30
-29
lines changed

1 file changed

+30
-29
lines changed

site/static/compare.html

Lines changed: 30 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,34 @@
1919
</div>
2020
<br />
2121
<div id="app">
22+
<h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{{before}}</span> and
23+
<span id="after">{{after}}</span>
24+
</h2>
25+
<div v-if="data" style="margin: 12px 0;">
26+
<div style="display: flex;justify-content: center;">
27+
<div class="description-box">
28+
<div v-if="data.prev" class="description-arrow"><a v-bind:href="prevLink">&larr;</a></div>
29+
<div style="padding: 10px;">
30+
<span><a v-if="data.a.pr" v-bind:href="prLink(data.a.pr)">#{{data.a.pr}}</a>&nbsp;</span>
31+
<span v-if="data.a.date">{{formatDate(data.a.date)}}</span>
32+
(<a v-bind:href="commitLink(data.a.commit)">{{short(data.a)}}</a>)
33+
</div>
34+
</div>
35+
<div v-if="notContinuous" id="not-continuous" title="WARNING! The commits are not continuous.">...
36+
</div>
37+
<div class="description-box">
38+
<div style="padding: 10px;">
39+
<span><a v-if="data.b.pr" v-bind:href="prLink(data.b.pr)">#{{data.b.pr}}</a>&nbsp;</span>
40+
<span v-if="data.b.date">{{formatDate(data.b.date)}}</span>
41+
(<a v-bind:href="commitLink(data.b.commit)">{{short(data.b)}}</a>)
42+
</div>
43+
<div v-if="data.next" class="description-arrow"><a v-bind:href="nextLink">&rarr;</a></div>
44+
</div>
45+
</div>
46+
<div style="display: flex; justify-content: center;">
47+
<a v-bind:href="compareLink">🔎 compare commits</a>
48+
</div>
49+
</div>
2250
<fieldset id="settings">
2351
<legend id="search-toggle" class="section-heading">Do another comparison<span
2452
class="toggle-indicator" id="search-toggle-indicator"></span></legend>
@@ -50,40 +78,13 @@
5078
<div v-for="metric in [
5179
['Instructions', 'instructions:u', 'Number of executed instructions'],
5280
['Cycles', 'cycles:u', 'Number of executed cycles'],
53-
['Max RSS', 'max-rss', 'Highest amount of total allocated memory during the course of the compilation'],
81+
['Wall time', 'wall-time', 'Wall time'],
82+
['Max RSS', 'max-rss', 'Peak memory usage (resident set size)'],
5483
['Binary size', 'size:linked_artifact', 'Size of the generated binary artifact']
5584
]" :class="{ active: stat === metric[1] }" :title="metric[2]">
5685
<a :href="createUrlForMetric(metric[1])">{{ metric[0] }}</a>
5786
</div>
5887
</div>
59-
<h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{{before}}</span> and
60-
<span id="after">{{after}}</span>
61-
</h2>
62-
<div v-if="data" style="margin: 12px 0;">
63-
<div style="display: flex;justify-content: center;">
64-
<div class="description-box">
65-
<div v-if="data.prev" class="description-arrow"><a v-bind:href="prevLink">&larr;</a></div>
66-
<div style="padding: 10px;">
67-
<span><a v-if="data.a.pr" v-bind:href="prLink(data.a.pr)">#{{data.a.pr}}</a>&nbsp;</span>
68-
<span v-if="data.a.date">{{formatDate(data.a.date)}}</span>
69-
(<a v-bind:href="commitLink(data.a.commit)">{{short(data.a)}}</a>)
70-
</div>
71-
</div>
72-
<div v-if="notContinuous" id="not-continuous" title="WARNING! The commits are not continuous.">...
73-
</div>
74-
<div class="description-box">
75-
<div style="padding: 10px;">
76-
<span><a v-if="data.b.pr" v-bind:href="prLink(data.b.pr)">#{{data.b.pr}}</a>&nbsp;</span>
77-
<span v-if="data.b.date">{{formatDate(data.b.date)}}</span>
78-
(<a v-bind:href="commitLink(data.b.commit)">{{short(data.b)}}</a>)
79-
</div>
80-
<div v-if="data.next" class="description-arrow"><a v-bind:href="nextLink">&rarr;</a></div>
81-
</div>
82-
</div>
83-
<div style="display: flex; justify-content: center;">
84-
<a v-bind:href="compareLink">🔎 compare commits</a>
85-
</div>
86-
</div>
8788
<fieldset id="filters" class="collapsible-section">
8889
<legend id="filters-toggle" class="section-heading">Filters<span class="toggle-indicator" id="filters-toggle-indicator"></span>
8990
</legend>

0 commit comments

Comments
 (0)