Compare page tweaks #1474
Merged
Compare page tweaks #1474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find myself looking at it often. And tweak the description for "Max RSS".
The "Comparing..." heading is now at the top, which is the sensible place for it. Also, the "Do another comparison" label now makes sense, coming after the heading.
nnethercote
force-pushed
the
compare-page-tweaks
branch
from
d14ed9d to
b0cc4a2
Compare
|
Old view: New view: |
Kobzol
approved these changes
Oct 19, 2022
|
I'm fine with this change, but the "do another comparison" section was above everything else previously because it is a search mechanism that impacts everything below it. In other words, it had the order:
Now the search input is mixed with the search result. Again, I'm fine with this if makes more sense to everyone, but I thought I'd just note that the previous order was on purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of things that have been bugging me for some time.