mono-item profiler #1016
Merged
mono-item profiler #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can see that be useful when trying to figure out why the cgu merging has changed. |
rylev
approved these changes
Sep 20, 2021
| let _ = fs::create_dir_all(&out_dir); | ||
| let result_file = filepath(&out_dir, "raw"); | ||
|
|
||
| fs::copy(&tmp_file, &result_file)?; |
There was a problem hiding this comment.
Are these result files severed from the site or is this currently only useable locally?
There was a problem hiding this comment.
These are all just usable locally, the perf collector server doesn't hit this function at all, I believe.
Eventually I'd like to surface this specific profile in the site - potentially integrated with the recently added codegen schedule graphs - but that's future work.
Mark-Simulacrum
force-pushed
the
mono-items
branch
from
49d64c7 to
13d1110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another profiler which runs the benchmark with -Zprint-mono-items and then slightly parses the output to split into per-CGU lists of mono items. These are the post-merging CGUs.
Posting this to get it merged into master; I'm using this locally to mediocre success but I feel like it is probably at least a little useful to have. Eventually I'd like to work some more on it and get this displayed as part of our results on each benchmark, so we can e.g. give warnings when CGU allocation changes. Potentially there's some useful work to show the "forest" of CGUs that got merged into the final set as well, but I am not sure that is genuinely helpful (vs. pretty).