Support directly rendering codegen scheduling #1019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily only works when using a db exported from the production Postgres, but that is sufficient for now.
|
This is really awesome! Feeling inspired to improve codegen scheduling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry picks a few of the commits from #1005 to build up the ability to use self profile with sqlite (currently using an export of the prod db locally).
The schedule is rendered onto canvas, essentially a subset of the view that crox (and then chrome profiler tooling) provides, but easier to get to and with significantly less complexity. We'll likely want to continue iterating on how to get to these views (currently integrated into the self profile page) and what exactly is displayed -- this isn't really going to mesh well with any kind of query nesting, but seems like a good start still.
Graph drawing is at least partly inspired by Cargo's -Ztimings view.
Example: