Skip to content

Show data for queries present only in one profile in comparison #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tgnottingham
Copy link
Contributor

Add showing rows for self-profile queries present only in base profile,
and add showing deltas for queries present only in main profile.

Fixes #1022.

Add showing rows for self-profile queries present only in base profile,
and add showing deltas for queries present only in main profile.

Fixes rust-lang#1022.
@tgnottingham
Copy link
Contributor Author

tgnottingham commented Sep 22, 2021

Where base profile doesn't have lit_to_const query (deltas are added):

comparison_positive

Where only base profile has lit_to_const query (row is added):

comparison_negative


For reference, here is the before:

Where base profile doesn't have lit_to_const query (deltas are missing):

comparison_positive_before

And for the other case, the row wasn't present before.

@tgnottingham
Copy link
Contributor Author

Added showing executions delta as integer as well:

integer_executions_delta

@Mark-Simulacrum
Copy link
Member

I think you should have permission to merge, so please do so when you think this is good -- I gave a quick skim and the changes look good to me :)

Generally don't feel you need to wait on review, particularly for UI improvements like this.

@tgnottingham
Copy link
Contributor Author

Alright, thanks!

@tgnottingham tgnottingham merged commit 61466f7 into rust-lang:master Sep 22, 2021
@tgnottingham tgnottingham deleted the show-uninvoked-self-profile-queries branch September 25, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detailed-query page missing some lines from table
2 participants