Update cargo-llvm-lines version and CI checks
#1030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An issue has been fixed in `cargo-llvm-lines` 0.4.12 which would cause us to fail whenever profiling a crate which had any crate dependencies. Update to 0.4.12 and add a CI check that profiles a crate with dependencies to exercise this case. The issue was that we would invoke a particular `cargo` executable and `cargo-llvm-lines` would invoke a different one. This would cause us to try to build the crate's dependencies a second time with the different `cargo`. The `EXPECT_ONLY_WRAPPED_RUSTC` check would detect this case and produce an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue has been fixed in
cargo-llvm-lines0.4.12 which would causeus to fail whenever profiling a crate which had any crate dependencies.
Update to 0.4.12 and add a CI check that profiles a crate with
dependencies to exercise this case.
The issue was that we would invoke a particular
cargoexecutable andcargo-llvm-lineswould invoke a different one. This would cause us totry to build the crate's dependencies a second time with the different
cargo. TheEXPECT_ONLY_WRAPPED_RUSTCcheck would detect this caseand produce an error.