Skip to content

Don't group testCases by benchmark/profile in comparison page #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

rylev
Copy link
Member

@rylev rylev commented Oct 11, 2021

Fixes #1068

This changes the comparison page in two major ways:

  • Test results are no longer grouped by benchmark/profile. Each test result exists independent of each other.
  • The raw results (which are less important than the percent change and significance factor) are moved to the end of each row.

I don't love how this looks, but I think the overall behavior is an improvement. Any thoughts on how we can make this look better?

image

@rylev rylev requested a review from Mark-Simulacrum October 11, 2021 15:54
@Mark-Simulacrum
Copy link
Member

I think we should make the raw results be right-aligned with each other to ease comparison if we're going to lay them out like this.

I think moving the scenario to its own column might be a good idea too, like it was before -- it helps me to be able to quickly scan to see what the major regression 'categories' are, and doing that in interleaved text is harder.

@rylev
Copy link
Member Author

rylev commented Oct 11, 2021

How about this?
image

@Mark-Simulacrum
Copy link
Member

Works for me! I don't have a strong opinion on whether the raw data columns should be last or first but we can iterate on that based on how this works out.

r=me

@rylev rylev merged commit e92928f into rust-lang:master Oct 11, 2021
@rylev rylev deleted the no-grouping branch October 11, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort by % change or signifiance factor in results page?
2 participants