Skip to content

Add triage for 2021-10-19 #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

rylev
Copy link
Member

@rylev rylev commented Oct 20, 2021

No description provided.

@rylev rylev requested a review from Mark-Simulacrum October 20, 2021 09:26
@@ -0,0 +1,96 @@
# 2021-10-19 Triage Log

A week where improvements outweigh regressions. The highlight of the week is the change to split out LLVM profile guided optimization (PGO) and using clang 13 to compile LLVM which led to improvements in many real world crates (e.g., cargo) in the range of 10%. Most regressions were limited and at most in the less than 1% range. We are seeing more performance changes in rollups which are supposed to be performance neutral. We'll have to decide how to best address this.
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW the splitting out of LLVM PGO is performance-neutral, it's purely the bump of bootstrap C++ compiler to clang 13 that brings the large wins here.

@Mark-Simulacrum
Copy link
Member

r=me

@Mark-Simulacrum Mark-Simulacrum merged commit 3ca4c1e into rust-lang:master Oct 20, 2021
@rylev rylev deleted the triage-2021-10-19 branch October 25, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants