Render collector invocations for local benchmarking #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just renders it with cachegrind pre-selected, but that can be easily modified locally. Should provide a reasonable "default" on-ramp, though. Currently using some CSS to force selection to the code block as a whole instead of subparts, but maybe this is too weird. Does make copying pretty quick.
|
@Mark-Simulacrum for changes like this can we get screenshots with what it looks like? |
|
Yeah, I can do that in the future. It's just adding a few text lines though - e.g. https://perf.rust-lang.org/detailed-query.html?commit=7a9ff746fe20a38a3adc0ac65e1789f6e4b099ad&base_commit=56dee7c49ecdec4c2c9eccc6ff966cf58847bda6&benchmark=regex-debug&run_name=full |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just renders it with cachegrind pre-selected, but that can be easily
modified locally. Should provide a reasonable "default" on-ramp, though.
Currently using some CSS to force selection to the code block as a whole instead
of subparts, but maybe this is too weird. Does make copying pretty quick.