Skip to content

Display arithmetic mean of benchmarks in compare site #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Display arithmetic mean of benchmarks in compare site #1125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ target
/cache/
/rust.git/
/rust/
rust-baseline
70 changes: 54 additions & 16 deletions site/static/compare.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,9 @@
align-items: center;
width: 20%;
}
.summary-wide {
width: 35%;
}
</style>
<script src="https://cdn.jsdelivr.net/npm/vue@2/dist/vue.js"></script>
</head>
Expand Down Expand Up @@ -262,6 +265,7 @@
</div>
</div>
<input id="submit" type="submit" value="Submit" onclick="submitSettings(); return false;">
</div>
</fieldset>
<h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{{before}}</span> and
<span id="after">{{after}}</span>
Expand Down Expand Up @@ -405,28 +409,33 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
<div v-for="summaryPair in Object.entries(summary)" style="display: flex;">
<span style="font-weight: bold; width: 30%; margin-left: 15%; text-transform: capitalize;">{{
summaryPair[0] }}:</span>
<div style="display: flex; justify-content: flex-end; width: 80%; margin-right: 15%;">
<span class="summary positive">
<div style="display: flex; justify-content: flex-end; width: 80%; margin-right: 5%;">
<span class="summary summary-wide positive">
{{summaryPair[1].regressions.toString().padStart(3, "&nbsp;")}}
<svg style="width:18px;height:18px" viewBox="0 0 24 24">
<path
d="M16,18L18.29,15.71L13.41,10.83L9.41,14.83L2,7.41L3.41,6L9.41,12L13.41,8L19.71,14.29L22,12V18H16Z">
d="M16,6L18.29,8.29L13.41,13.17L9.41,9.17L2,16.59L3.41,18L9.41,12L13.41,16L19.71,9.71L22,12V6H16Z">
</path>
</svg>
&nbsp;(+{{(summaryPair[1].regressions_avg).toFixed(2)}}%)
</span>
<span class="summary">
{{summaryPair[1].unchanged.toString().padStart(3, "&nbsp;")}}
<svg style="width:18px;height:18px" viewBox="0 0 24 24">
<path d="M22,12L18,8V11H3V13H18V16L22,12Z"></path>
</svg>
</span>
<span class="summary negative">
<span class="summary summary-wide negative">
{{summaryPair[1].improvements.toString().padStart(3, "&nbsp;")}}
<svg style="width:18px;height:18px" viewBox="0 0 24 24">
<path
d="M16,6L18.29,8.29L13.41,13.17L9.41,9.17L2,16.59L3.41,18L9.41,12L13.41,16L19.71,9.71L22,12V6H16Z">
d="M16,18L18.29,15.71L13.41,10.83L9.41,14.83L2,7.41L3.41,6L9.41,12L13.41,8L19.71,14.29L22,12V18H16Z">
</path>
</svg>
&nbsp;({{(summaryPair[1].improvements_avg).toFixed(2)}}%)
</span>
<span class="summary" v-bind:class="percentClass(summaryPair[1].average)">
&nbsp;{{ signIfNegative(summaryPair[1].average) }}{{ (summaryPair[1].average).toFixed(2) }}%
</span>
</div>
</div>
Expand Down Expand Up @@ -706,25 +715,48 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
sum[testCaseString(next)] = true;
return sum;
}, {});
const newCount = { regressions: 0, improvements: 0, unchanged: 0 }
const newCount = {
regressions: 0,
regressions_avg: 0,
improvements: 0,
improvements_avg: 0,
unchanged: 0,
average: 0
};

const addDatum = (result, datum, percent) => {
if (percent > 0 && datum.is_significant) {
result.regressions += 1;
result.regressions_avg += percent;
} else if (percent < 0 && datum.is_significant) {
result.improvements += 1;
result.improvements_avg += percent;
} else {
result.unchanged += 1;
}
result.average += percent;
};

let result = { all: { ...newCount }, filtered: { ...newCount } }
for (let d of this.data.comparisons) {
const testCase = testCaseString(d)
const scenario = d.scenario;
const datumA = d.statistics[0];
const datumB = d.statistics[1];
let percent = 100 * ((datumB - datumA) / datumA);
if (percent > 0 && d.is_significant) {
result.all.regressions += 1;
result.filtered.regressions += filtered[testCase] || 0;
} else if (percent < 0 && d.is_significant) {
result.all.improvements += 1;
result.filtered.improvements += filtered[testCase] || 0;
} else {
result.all.unchanged += 1;
result.filtered.unchanged += filtered[testCase] || 0;
addDatum(result.all, d, percent);
if (filtered[testCase]) {
addDatum(result.filtered, d, percent);
}
}

const computeAvg = (result) => {
result.improvements_avg /= Math.max(result.improvements, 1);
result.regressions_avg /= Math.max(result.regressions, 1);
result.average /= Math.max(result.regressions + result.improvements + result.unchanged, 1);
};
computeAvg(result.all);
computeAvg(result.filtered);

return result;

}
Expand All @@ -736,6 +768,12 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
prLink(pr) {
return `https://github.com/rust-lang/rust/pull/${pr}`;
},
signIfNegative(pct) {
if (pct >= 0) {
return "";
}
return "-";
},
percentClass(pct) {
let klass = "";
if (pct > 1) {
Expand Down