Skip to content

List new errors on comparison page #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

Mark-Simulacrum
Copy link
Member

failing benchmark

Failing benchmarks should also be listed in summaries posted to issues -- and onto the triage reports.

Closes #1062

@Mark-Simulacrum Mark-Simulacrum merged commit 0aa4d6e into rust-lang:master Dec 21, 2021
@Mark-Simulacrum Mark-Simulacrum deleted the errors-on-compare branch December 21, 2021 16:08
@Aaron1011
Copy link
Member

Could we also display all broken benchmarks, regardless of when they were broken? I think it could be easy to forget about a broken benchmark with the current setup.

@lqd
Copy link
Member

lqd commented Dec 21, 2021

The currently broken benchmarks are shown at the bottom of the status page https://perf.rust-lang.org/status.html (webrender-wrench rn) did you have something different in mind ? edit: ah you mean on all comparison pages, right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display/note error messages when builds fail in the collector
3 participants