Improve the summary message both in GitHub and in the triage report #1156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the summaries generated for both the perf bot on GitHub as well as the weekly triage report.
Note: I've not tested this locally as I don't have a local database in a useable form anymore.
Perf Bot
before
Summary: This change led to large relevant regressions 😿 in compiler performance.
incr-patched: reverse
builds ofregex check
)after
Summary: This benchmark run shows 10 relevant regressions 😿 to instruction counts.
incr-patched: reverse
builds ofregex check
Triage Report
before
full
builds ofkeccak check
)after
full
builds ofkeccak check
Other Changes
Additionally, this PR changes the message slightly when there are no "relevant" changes (and thus nothing needs to be done) but there are still some (small) statistically significant changes. The following is added in the perf bot message.
"N results were found to be statistically significant but too small to be relevant."