Skip to content

Clip 'Fork me on GitHub' buttons #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Feb 8, 2022

The site is otherwise unusable on some mobile browsers because the clickable area of the 'Fork me on GitHub' button from #167 completely covers the instructions:u dropdown.

Clickable area before:

Screenshot from 2022-02-07 18-01-39

Clickable area after:

Screenshot from 2022-02-07 18-01-49

Switching to https://github.com/simonwhitaker/github-fork-ribbon-css would be a good alternative fix.

@Mark-Simulacrum
Copy link
Member

This seems ok to me - some of the pages just have this on the bottom and some omit it entirely I think, which might be a better approach. This seems like a good start though.

@Mark-Simulacrum Mark-Simulacrum merged commit 5ac2fbb into rust-lang:master Feb 8, 2022
@dtolnay dtolnay deleted the clip branch February 8, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants