Add DhatCopy as a profiler.
#1192
Conversation
There was a problem hiding this comment.
Looks good, though seems like CI is too old for the copy mode to be available. Not sure what we should do about that; it seems like we're using latest Ubuntu LTS currently. One approach might be to run the test in Docker in a more recent Ubuntu, but that seems like a lot of hassle. I do think we should try to add a test of some kind though...
|
I'm on Ubuntu 21.10 and I have Valgrind 3.17, which works with The easy thing here is to just comment out the test and add a FIXME comment. We are already testing vanilla DHAT, so we're not really losing that much by not testing DHAT-copy... |
|
Yeah, that seems OK for now. 22.04 should be out soon and we can bump to that once GitHub upgrades, which should allow uncommenting the extra test case. |
This is DHAT running in "copy mode", which profiles `memcpy`/`memmove` calls instead of allocations. I have found it useful numerous times but I've always had to invoke it for rustc-perf by just modifying the existing DHAT invocation. Time to provide an easier way of doing it.
nnethercote
force-pushed
the
add-dhat-copy
branch
from
b22164d to
8b33793
Compare
This is DHAT running in "copy mode", which profiles
memcpy/memmovecalls instead of allocations. I have found it useful numerous times but
I've always had to invoke it for rustc-perf by just modifying the
existing DHAT invocation. Time to provide an easier way of doing it.