Remove .git directory when downloading a crate from git(hub) #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
reviewed
Mar 22, 2022
|
Do we capture the sha we downloaded into the directory currently? It might be nice to write a git-commit.txt or something with that information, so that there's an easy way to know what was downloaded. |
|
Good idea, I added it. |
rylev
approved these changes
Mar 23, 2022
|
I assume that pretty much all of the (new) benchmarks currently in the repository are downloaded not from git(hub), but from The download from git is more useful for local profiling and downloading e.g. personal projects from github that are mentioned in |
|
Ah good point! I'll merge then 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.gitdirectory should not be kept there.