Skip to content

Some cleanups #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Some cleanups #1227

merged 3 commits into from
Mar 22, 2022

Conversation

nnethercote
Copy link
Contributor

Some cleanups in rustc-fake.rs.

`Command` can redirect stdout/stderr to file with `Command`, without
resorting to bash redirection, and `TimePasses` already does that. This
commit changes `Eprintln` and `MonoItems` to do that as well, which
means `bash_command` is no longer necessary.
Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have one nit, but we can merge with or without that addressed.

@nnethercote nnethercote merged commit 309aaa4 into rust-lang:master Mar 22, 2022
@nnethercote nnethercote deleted the some-cleanups branch March 22, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants