Skip to content

Remove clap-rs #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2022
Merged

Remove clap-rs #1235

merged 2 commits into from
Mar 24, 2022

Conversation

nnethercote
Copy link
Contributor

It has been superseded by clap-3.1.6.

@nnethercote
Remove clap-rs.
7e911f2 
It has been superseded by `clap-3.1.6`.
@nnethercote
Remove clap-rs from the README.
8c62813 
Also move `image-0.24.1` lower down, to keep the list in alphabetical
order.
@nnethercote nnethercote requested a review from lqd March 24, 2022 03:22
lqd
lqd approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lqd
Copy link
Member

lqd commented Mar 24, 2022 •
edited
Loading

rustc CI still uses it for PGO so I'm not sure how to handle that: should be switch the CI to the new clap-3.1.6 first before removing it from here, or will CI ignore it if it's missing ? edit: I remember, rustc CI uses a pinned rustc-perf version

@rylev rylev merged commit 25fa133 into rust-lang:master Mar 24, 2022
@nnethercote nnethercote deleted the rm-clap-old branch March 27, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnethercote @lqd @rylev