Skip to content

Add syn-1.0.89 benchmark #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Conversation

rylev
Copy link
Member

@rylev rylev commented Mar 24, 2022

This adds the syn-1.0.89 as a benchmark. Here is the comparison in total build times:

  • syn:
    • check: 1.64s
    • build: 1.91s
    • build --release: 2.87s
  • syn-1.0.89 (full/without deps):
    • check: 1.97s/1.22s
    • build: 2.89s/2.01s
    • build --release: 4.65s/3.99s

Overall build times are roughly in the same ballpark with the new version compiling a bit slower overall.

As for cpu-clock:u (again, I can't measure cycles on my machine):

image

Overall, it looks like this will return relevant results (possibly even more so than the older benchmark).

@rylev rylev requested a review from nnethercote March 24, 2022 13:51
Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, otherwise good. Please don't merge this until the current site breakage is resolved.

@rylev rylev force-pushed the add-syn-1.0.89-benchmark branch from a988a5b to 0fedb67 Compare March 25, 2022 10:07
@rylev rylev force-pushed the add-syn-1.0.89-benchmark branch from 0fedb67 to 82004a6 Compare March 25, 2022 10:08
Timings:
*syn:
  * check: 1.64s
  * build: 1.91s
  * build --release: 2.87s
* syn-1.0.89 (full/final):
  * check: 1.97s/1.22s
  * build: 2.89s/2.01s
  * build --release: 4.65s/3.99s
@rylev rylev changed the title Add syn 1.0.89 benchmark Add syn-1.0.89 benchmark Mar 25, 2022
@rylev rylev merged commit cf072f3 into rust-lang:master Mar 25, 2022
@rylev rylev deleted the add-syn-1.0.89-benchmark branch March 25, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants