Skip to content

Add unicode-normalization-0.1.19 benchmark #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Mar 24, 2022

Time for compiling the whole crate did increase very slightly:

        unicode_normalization   unicode-normalization-0.1.19
check   1.22s     1.72s
debug   1.32s     2.01s
opt     1.46s     2.12s

Instruction counts have decreased, so it's possible that the increase above is caused by dependencies. In any case, it's quite similar as before:
image

I'm not sure where are those "huge match statements that stress the compiler in unusual ways." though. Are they macro generated? 🤔

@nnethercote
Copy link
Contributor

I'm not sure where are those "huge match statements that stress the compiler in unusual ways." though. Are they macro generated? thinking

Look in src/tables.rs.

Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nnethercote
Copy link
Contributor

Please don't merge this until the current site breakage is resolved.

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 25, 2022

I'm not sure where are those "huge match statements that stress the compiler in unusual ways." though. Are they macro generated? thinking

Look in src/tables.rs.

Oh, I was looking at the GitHub diff for the matches and this file was collapsed because it is too big :) Thanks.

@Kobzol Kobzol merged commit 96aeeb3 into master Mar 25, 2022
@Kobzol Kobzol deleted the unicode-normalization-0.1.19 branch March 25, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants