Add webrender 2022 again
#1252
Merged
Add webrender 2022 again
#1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's how I obtained it. It required a little dance because the repo name `webrender` is the same as the existing benchmark `webrender`. ``` mv collector/benchmarks/webrender collector/benchmarks/webrender-old target/release/collector download -c primary git https://github.com/servo/webrender mv collector/benchmarks/webrender collector/benchmarks/webrender-2022 mv collector/benchmarks/webrender-old collector/benchmarks/webrender git add collector/benchmarks/webrender-2022 ```
Here's the overall time to `full` compile everything, webrender vs
webrender-2022:
```
old new
- check 15.8s 21.9s
- debug 19.5s 28.4s
- opt 25.0s 38.9s
```
Roughly 1.5x longer.
And here's the time to `full` compile just the final crate:
```
old new
- check 1.74s 4.28s
- debug 4.70s 9.92s
- opt 9.58s 19.14s
```
Roughly 2x longer.
rylev
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
FYI: I believe it was backed out in #1242 when we were unsure what was causing the issues with the status page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webrender-2022was originally added in #1236, then backed out in #1237. Let's try again.