Add html5ever 0.26.0 #1257
Merged
Add html5ever 0.26.0 #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall compile times:
```
html5ever html5ever-0.26.0
check 4.1s 7.8s
debug 4.4s 8.0s
opt 4.7s 7.3s
```
Compile times for the final crate:
```
helloworld html5ever html5ever-0.26.0
check 0.16 1.10 0.58
debug 0.23 1.37 0.69
opt 0.22 1.65 0.81
```
The final crate is quite a bit smaller, especially relative to the overall
time. I looked at Cachegrind profiles, it seems like html5ever-0.26.0 is even
more of a macro expanstion + AST handling stress test, because that stuff is a
bigger proportion. So I think it's still reasonable to include it.
rylev
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall compile times:
Compile times for the final crate:
Quite a bit smaller. I looked at Cachegrind profiles, it seems like
html5ever-0.26.0 is even more of a macro expanstion + AST handling stress test,
because that stuff is a bigger proportion. So I think it's still reasonable to
include it.