Skip to content

Add missing newline and remove duplicate header from PR summary #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2022
Merged

Add missing newline and remove duplicate header from PR summary #1268

merged 1 commit into from
Apr 1, 2022

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 1, 2022

Fixes this.

I'm pretty sure that the main problem was missing newline after the short summary.

@Kobzol Kobzol requested a review from lqd April 1, 2022 13:25
lqd
lqd approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newlines could also be added to the format string but that's no big deal.

👍

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 1, 2022

It was a raw literal, so I couldn't use \n and would have to add actual empty newlines which would look weird. Anyway, let's see if it helped.

@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 1, 2022

Merging to fix this asap, hopefully it helps.

@Kobzol Kobzol merged commit 86bb871 into master Apr 1, 2022
@Kobzol Kobzol deleted the fix-summary branch April 1, 2022 13:40
@lqd lqd mentioned this pull request Apr 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kobzol @lqd