Skip to content

Limit the inclusion of some artifact comparisons in triage #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

rylev
Copy link
Member

@rylev rylev commented Apr 7, 2022

As a follow up to #1281, this adds back some filtering to the triage report.

Specifically, artifact comparisons will only be included in the triage report if they fit one or more of the following conditions:

  • 1 or more test result comparisons with medium or greater magnitude
  • A combined number of test result comparisons for primary and secondary benchmarks that make the following true: (#primary * 2 + #secondary) >= 6.

This filters out a considerable number of artifact comparisons where only 1 or 2 small test result comparisons are relevant.

cc @Mark-Simulacrum @pnkfelix

Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with the comment below addressed. Thanks.

@rylev rylev merged commit c7cce59 into rust-lang:master Apr 8, 2022
@rylev rylev deleted the limit-triage branch April 8, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants