Skip to content

Add new tt-muncher benchmark. #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

nnethercote
Copy link
Contributor

It's a good stress test for macro expansion. I've been using it locally
for a while.

Times taken for from-scratch, non-incremental builds:

  • check 1.4s
  • debug 2.6s
  • opt 3.2s

It's a good stress test for macro expansion. I've been using it locally
for a while.

Times taken for from-scratch, non-incremental builds:
- check  1.4s
- debug  2.6s
- opt    3.2s
@nnethercote nnethercote requested a review from lqd April 11, 2022 00:25
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Macro expansion looks good as a secondary use-case. The benchmark's runtime isn't prohibitively long and we have some spare capacity right now.

👍

Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It's not obvious how and why quote is modified. Can we document that somewhere?

@nnethercote
Copy link
Contributor Author

I expanded on the comment within the modified quote.

@nnethercote nnethercote enabled auto-merge April 11, 2022 08:48
@nnethercote nnethercote merged commit d7eaf4a into rust-lang:master Apr 11, 2022
@nnethercote nnethercote deleted the add-tt-muncher branch April 11, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants