Prefer the term metric over stat #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the code uses the term "stat" ambiguously. Sometimes it refers to a specific number statistic (e.g., 57,341,606,128 instruction counts recorded), and sometimes it refers to a class of statistic (e.g., "instruction counts"). The glossary disambiguates these two using the term "stat(istic)" for the former and "metric" for the later. This PR brings the code into alignment with the glossary.
Note: the API still uses "stat" for what is now called "metric". Since change the API is a little more error prone, I suggest we save that for a follow-up.