Make summary table vertical #1334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
reviewed
May 24, 2022
Kobzol
force-pushed
the
summary-table-vertical
branch
from
4d511a5 to
474100b
Compare
rylev
requested changes
May 24, 2022
rylev
approved these changes
May 24, 2022
nnethercote
added a commit
to nnethercote/rustc-perf
that referenced
this pull request
Oct 28, 2022
The table spacing was made nice in rust-lang#1312 but then got messed up again in rust-lang#1334. This commit does the following. - Fixes the table spacing. - Changes how test failures are printed, so the expected and actual outputs are printed nicely across multiple lines, instead of being stringified with into a single line. I should have done this some time ago, it makes adjusting the expected output *so* much easier. - Renames some variables, for clarity and consistency. - Imports `std::cmp` because it's used in multiple places. - Other minor tweaks.
nnethercote
added a commit
to nnethercote/rustc-perf
that referenced
this pull request
Oct 28, 2022
The table spacing was made nice in rust-lang#1312 but then got messed up again in rust-lang#1334. This commit does the following. - Fixes the table spacing. - Changes how test failures are printed, so the expected and actual outputs are printed nicely across multiple lines, instead of being stringified with into a single line. I should have done this some time ago, it makes adjusting the expected output *so* much easier. - Renames some variables, for clarity and consistency. - Imports `std::cmp` because it's used in multiple places. - Other minor tweaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Zulip discussion. The current look of the table can be seen here.
The table is now vertical.
I refactored the code to build a sort of a 2D matrix of values (
Vec<Vec<String>>), so that it is easier to change the horizontal/vertical layout or column/row order in the future.