Skip to content

Increase tracelog buffer sizes #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Increase tracelog buffer sizes #1346

merged 1 commit into from
Jun 16, 2022

Conversation

lqd
Copy link
Member

@lqd lqd commented Jun 16, 2022

Otherwise a lot of the benchmarks trigger errors and warnings about lost
events while profiling rust-lang/rust#96978, for example (pardon my french ...xperf):

xperf: error: rustc-perf-counters: Le nom d'instance passé n'a pas été
reconnu valide par un fournisseur de données WMI. (0x1069).
xperf: warning: Session "rustc-perf-counters" lost 5204 events.

I'm not sure if that's an artifact of the box I have access to, or if e. g. @wesleywiser you've seen this happen in your benchmarking endeavours as well ?

(I'm also not sure if increasing both xperf and tracelog buffers is necessary or if only one or the other would suffice. Tracelog at the very least should be IIRC update: this PR now only changes the tracelog buffers)

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default buffer sizes haven't been too small when I've profiled rustc but I've definitely run into that issue before on other projects so this seems reasonable to me modulo the xperf change 🙂

Otherwise a lot of the benchmarks trigger errors and warnings about lost
events, for example (pardon my french ...xperf):

```
xperf: error: rustc-perf-counters: Le nom d'instance passé n'a pas été
reconnu valide par un fournisseur de données WMI. (0x1069).
xperf: warning: Session "rustc-perf-counters" lost 5204 events.
```
@lqd lqd changed the title increase xperf and tracelog buffer sizes Increase tracelog buffer sizes Jun 16, 2022
@wesleywiser wesleywiser enabled auto-merge June 16, 2022 15:22
@wesleywiser wesleywiser merged commit 11888e3 into rust-lang:master Jun 16, 2022
@lqd lqd deleted the win-xperf branch June 16, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants