Increase tracelog buffer sizes #1346
Merged
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise a lot of the benchmarks trigger errors and warnings about lost
events while profiling rust-lang/rust#96978, for example (pardon my french ...xperf):
I'm not sure if that's an artifact of the box I have access to, or if e. g. @wesleywiser you've seen this happen in your benchmarking endeavours as well ?
(
I'm also not sure if increasing both xperf and tracelog buffers is necessary or if only one or the other would suffice. Tracelog at the very least should be IIRCupdate: this PR now only changes the tracelog buffers)