Skip to content

Process rollup in the background #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2022
Merged

Process rollup in the background #1378

merged 1 commit into from
Aug 1, 2022

Conversation

rylev
Copy link
Member

@rylev rylev commented Aug 1, 2022

GitHub has a timeout of 10 seconds for its web hooks which does not seem configurable. This moves processing to the background. This might make debugging slightly more tedious, but other than that I don't think this is worse than the satus quo.

@rylev rylev requested a review from Mark-Simulacrum August 1, 2022 20:14
Mark-Simulacrum
Mark-Simulacrum approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does mean that we might get killed by ECS if there's a deployment in progress, but the overlap there is hopefully pretty small. We might want a command that manually triggers the logic so you can run it on a rollup if needed.

@Mark-Simulacrum Mark-Simulacrum merged commit da508f4 into rust-lang:master Aug 1, 2022
@rylev rylev deleted the process-in-the-background branch August 1, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rylev @Mark-Simulacrum