Change 😿🎉 to ❌✅ in github comments. #1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current emoji are cute. But they're both mostly yellow, contain fine detail that is hard to see at smaller font sizes, and don't have clear meanings. This commit changes them to a green check and a red cross, which are easier to distinguish and clearer in meaning.
nnethercote
force-pushed
the
better-emoji
branch
from
758dfea to
60824e1
Compare
nnethercote
changed the title
Mark-Simulacrum
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current emoji are cute. But they're both mostly yellow, contain fine
detail that is hard to see at smaller font sizes, and don't have clear
meanings.
This commit changes them to a green check and a red cross, which are
easier to distinguish and clearer in meaning.