Add branch-misses and cache-misses to stats collected by perf stat
#1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Confirmed availability on the runner.
I'll also note we have a finite amount of metrics available that require hardware counters (iirc, 5), but we're not hitting that limit quite yet -- only instructions, cycles, and now branch and cache misses are in that number I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These metrics are quite fundamental in my opinion, and I think that adding them to
perf statshouldn't really affect a lot of things, since it already gathers a lot of other stats. Even though these metrics will probably be quite noisy, I think that they can still be useful in the dashboard.branch-missesandcache-missesare in fact aliases forperf, which chooses some inner metric to calculate these. I think that these alises should be available on the perf runner.