Direction lattice
#1395
Merged
Direction lattice
#1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `Direction`s are combined in two places. - `populate_report`, which uses a match. It gives the primary and secondary directions equal weight. - `summarize_run`, which uses `Option::or`. It gives the primary direction more weight; the secondary direction will only be used if the primary direction is `None`. The latter seems suboptimal. If, for example, there are only improvements in the primary benchmarks and only regressions in the secondary benchmarks, the overall result should be "mixed results" not "improvements". This commit makes both places use the combination from `populate_report`. `Direction` forms a simple lattice and that combination is the "join" operation. `Option` is no longer needed.
rylev
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed one commit at a time.