Store try commit dates into the DB properly #1399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `BenchNext` command will no longer use fake commits, but use the actual commit returned from `next_commit`.
Mark-Simulacrum
approved these changes
Aug 12, 2022
This was referenced Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another follow-up to #1357 and #1393. It makes the following changes:
/perf/next_commitnow returns the actual commit that can be inserted (or used as a lookup) into the DB as-is.pull_request_buildtable got a new column namedcommit_date, which stores the date at which thebors_shawas committed.With these two changes, the actual build dates of
trycommits should now be hopefully propagated to theartifacttable and thus to the 30-day graphs.The
commit_datecolumn is currently optional (nullable) and set toNULLfor master commits, as we don't need the dates for them.