Add summary table to compare page #1404
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,6 +6,29 @@ function findQueryParam(name) { | |||||
| } | ||||||
| } | ||||||
|
|
||||||
| function createDefaultFilter() { | ||||||
| return { | ||||||
| name: null, | ||||||
| nonRelevant: false, | ||||||
| profile: { | ||||||
| check: true, | ||||||
| debug: true, | ||||||
| opt: true, | ||||||
| doc: true | ||||||
| }, | ||||||
| scenario: { | ||||||
| full: true, | ||||||
| incrFull: true, | ||||||
| incrUnchanged: true, | ||||||
| incrPatched: true | ||||||
| }, | ||||||
| category: { | ||||||
| primary: true, | ||||||
| secondary: true | ||||||
| } | ||||||
| }; | ||||||
| } | ||||||
|
|
||||||
| const app = Vue.createApp({ | ||||||
| mounted() { | ||||||
| const app = this; | ||||||
|
|
@@ -20,26 +43,7 @@ const app = Vue.createApp({ | |||||
| }, | ||||||
| data() { | ||||||
| return { | ||||||
| filter: createDefaultFilter(), | ||||||
| showRawData: false, | ||||||
| data: null, | ||||||
| dataLoading: false | ||||||
|
|
@@ -103,7 +107,7 @@ const app = Vue.createApp({ | |||||
| let nameFilter = filter.name && filter.name.trim(); | ||||||
| nameFilter = !nameFilter || name.includes(nameFilter); | ||||||
|
|
||||||
| const relevanceFilter = filter.nonRelevant ? true : testCase.isRelevant; | ||||||
|
|
||||||
| return ( | ||||||
| profileFilter(testCase.profile) && | ||||||
|
|
@@ -219,56 +223,9 @@ const app = Vue.createApp({ | |||||
| stat() { | ||||||
| return findQueryParam("stat") || "instructions:u"; | ||||||
| }, | ||||||
| // Returns summary of currently filtered data | ||||||
| filteredSummary() { | ||||||
| return computeSummary(this.testCases); | ||||||
| }, | ||||||
| benchmarkMap() { | ||||||
| if (!this.data) return {}; | ||||||
|
|
@@ -289,12 +246,6 @@ const app = Vue.createApp({ | |||||
| prLink(pr) { | ||||||
| return `https://github.com/rust-lang/rust/pull/${pr}`; | ||||||
| }, | ||||||
| diffClass(diff) { | ||||||
| let klass = ""; | ||||||
| if (diff > 1) { | ||||||
|
|
@@ -331,6 +282,9 @@ const app = Vue.createApp({ | |||||
|
|
||||||
| return createUrlFromParams(createSearchParamsForMetric(metric, start, end)); | ||||||
| }, | ||||||
| resetFilter() { | ||||||
| this.filter = createDefaultFilter(); | ||||||
| } | ||||||
| }, | ||||||
| }); | ||||||
|
|
||||||
|
|
@@ -433,6 +387,86 @@ app.component('test-cases-table', { | |||||
| </div> | ||||||
| ` | ||||||
| }); | ||||||
|
|
||||||
| const SummaryPercentValue = { | ||||||
| props: { | ||||||
| value: Number, | ||||||
| padWidth: { | ||||||
| type: Number, | ||||||
| default: null | ||||||
| } | ||||||
| }, | ||||||
| template: ` | ||||||
| <span><span v-html="padSpaces" />{{ formattedValue }}%</span> | ||||||
| `, | ||||||
| computed: { | ||||||
| formattedValue() { | ||||||
| return `${this.signIfPositive(this.value)}${this.value.toFixed(2)}`; | ||||||
| }, | ||||||
| padSpaces() { | ||||||
| let value = this.formattedValue; | ||||||
| if (value.length < this.padWidth) { | ||||||
| return " ".repeat(this.padWidth - value.length); | ||||||
| } | ||||||
| return ""; | ||||||
| } | ||||||
| } | ||||||
| }; | ||||||
| const SummaryRange = { | ||||||
| props: { | ||||||
| range: Array, | ||||||
| }, | ||||||
| template: ` | ||||||
| <div v-if="range.length > 0"> | ||||||
| [<SummaryPercentValue :value="range[0]" :padWidth="6" />, <SummaryPercentValue :value="range[1]" :padWidth="6" />] | ||||||
| </div> | ||||||
| <div v-else>-</div> | ||||||
| `, components: {SummaryPercentValue} | ||||||
| }; | ||||||
| const SummaryCount = { | ||||||
| props: { | ||||||
| cases: Number, | ||||||
| benchmarks: Number | ||||||
| }, | ||||||
| template: ` | ||||||
| <span :title="cases + ' test case(s), ' + benchmarks + ' unique benchmark(s)'">{{ cases }} ({{ benchmarks }})</span> | ||||||
| ` | ||||||
| }; | ||||||
|
|
||||||
| app.component('summary-table', { | ||||||
| props: ['cases'], | ||||||
| template: ` | ||||||
| <table class="summary-table"> | ||||||
| <thead> | ||||||
| <th><!-- icon --></th> | ||||||
| <th>Range</th> | ||||||
| <th>Mean</th> | ||||||
| <th>Count</th> | ||||||
| </thead> | ||||||
| <tbody> | ||||||
| <tr class="positive"> | ||||||
| <td title="Regresions">❌</td> | ||||||
|
There was a problem hiding this comment.
Suggested change
There was a problem hiding this comment. Oops :) Thanks. Will fix in #1410 if it gets merged, otherwise I'll send a separate PR. |
||||||
| <td><SummaryRange :range="cases.regressions.range" /></td> | ||||||
| <td><SummaryPercentValue :value="cases.regressions.average" /></td> | ||||||
| <td><SummaryCount :cases="cases.regressions.count" :benchmarks="cases.regressions.benchmarks" /></td> | ||||||
| </tr> | ||||||
| <tr class="negative"> | ||||||
| <td title="Improvements">✅</td> | ||||||
| <td><SummaryRange :range="cases.improvements.range" /></td> | ||||||
| <td><SummaryPercentValue :value="cases.improvements.average" /></td> | ||||||
| <td><SummaryCount :cases="cases.improvements.count" :benchmarks="cases.improvements.benchmarks" /></td> | ||||||
| </tr> | ||||||
| <tr> | ||||||
| <td title="All changes">❌,✅</td> | ||||||
| <td><SummaryRange :range="cases.all.range" /></td> | ||||||
| <td><SummaryPercentValue :value="cases.all.average" /></td> | ||||||
| <td><SummaryCount :cases="cases.all.count" :benchmarks="cases.all.benchmarks" /></td> | ||||||
| </tr> | ||||||
| </tbody> | ||||||
| </table> | ||||||
| `, | ||||||
| components: {SummaryRange, SummaryPercentValue, SummaryCount} | ||||||
| }); | ||||||
| app.mixin({ | ||||||
| methods: { | ||||||
| percentClass(pct) { | ||||||
|
|
@@ -448,6 +482,12 @@ app.mixin({ | |||||
| } | ||||||
| return klass; | ||||||
| }, | ||||||
| signIfPositive(pct) { | ||||||
rylev marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| if (pct >= 0) { | ||||||
| return "+"; | ||||||
| } | ||||||
| return ""; | ||||||
| }, | ||||||
| } | ||||||
| }); | ||||||
|
|
||||||
|
|
@@ -470,6 +510,69 @@ function testCaseString(testCase) { | |||||
| return testCase.benchmark + "-" + testCase.profile + "-" + testCase.scenario; | ||||||
| } | ||||||
|
|
||||||
| /** | ||||||
| * Computes summaries of improvements, regressions and all changes from the given `comparisons`. | ||||||
| * Returns a dictionary {improvements, regressions, all}. | ||||||
| */ | ||||||
| function computeSummary(testCases) { | ||||||
| const regressions = { | ||||||
| values: [], | ||||||
| benchmarks: new Set(), | ||||||
| }; | ||||||
| const improvements = { | ||||||
| values: [], | ||||||
| benchmarks: new Set(), | ||||||
| }; | ||||||
| const all = { | ||||||
| values: [], | ||||||
| benchmarks: new Set(), | ||||||
| }; | ||||||
|
|
||||||
| const handleTestCase = (items, testCase) => { | ||||||
| items.benchmarks.add(testCase.benchmark); | ||||||
| items.values.push(testCase.percent); | ||||||
| }; | ||||||
|
|
||||||
| for (const testCase of testCases) { | ||||||
| if (testCase.percent > 0) { | ||||||
| handleTestCase(regressions, testCase); | ||||||
| } else if (testCase.percent < 0) { | ||||||
| handleTestCase(improvements, testCase); | ||||||
| } | ||||||
| handleTestCase(all, testCase); | ||||||
| } | ||||||
|
|
||||||
| const computeSummary = (data) => { | ||||||
| const values = data.values; | ||||||
| const benchmarks = data.benchmarks; | ||||||
|
|
||||||
| const count = values.length; | ||||||
| let range = []; | ||||||
| if (count > 0) { | ||||||
| range = [ | ||||||
| Math.min.apply(null, values), | ||||||
| Math.max.apply(null, values), | ||||||
| ]; | ||||||
| } | ||||||
|
|
||||||
| const sum = values.reduce((acc, item) => acc + item, 0); | ||||||
| const average = sum / Math.max(count, 1); | ||||||
|
|
||||||
| return { | ||||||
| count, | ||||||
| benchmarks: benchmarks.size, | ||||||
| average, | ||||||
| range, | ||||||
| } | ||||||
| }; | ||||||
|
|
||||||
| return { | ||||||
| improvements: computeSummary(improvements), | ||||||
| regressions: computeSummary(regressions), | ||||||
| all: computeSummary(all) | ||||||
| }; | ||||||
| } | ||||||
|
|
||||||
| function unique(arr) { | ||||||
| return arr.filter((value, idx) => arr.indexOf(value) == idx); | ||||||
| } | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.