Add artifact size to compare page quick links #1418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Artifact is a bit general, so maybe it could be something like "Binary size"? |
|
@Kobzol Artifact size is already being used to track the sizes of all build artifacts (e.g., incremental compilation caches). If this is just the end binary size, I agree that we should make this clearer. |
Also adds a short summary of the metric
Kobzol
force-pushed
the
quick-links-artifact-size
branch
from
e1c03fd to
f2ddde1
Compare
|
The "technical" term is "linked artifact", I think that binary size is a friendly enough name for this. I changed the name of the quick link to |
rylev
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a short summary of the metric. I don't think that it's obvious to most people what metric corresponds to the artifact (binary) size of the compiled crate (well, I got it wrong :D ), so we might as well add it to the quick links.