Skip to content

Add a filter for try commits in graphs, compare page and triage #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2022

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Oct 2, 2022

Before these changes, try commits could appear in graphs/index page (when no filter was selected), compare page start/end bounds (when no bound was selected) and also in triage I think.

Fixes: #1406

@Kobzol Kobzol requested a review from Mark-Simulacrum October 2, 2022 07:19
Kobzol added 2 commits October 2, 2022 09:48
In a single graph, we want to also see try commits at the bounds (start/end), since sometimes we want to show a graph that ends in a try commit. For the graphs overview on the index page, we always want to see only master commits.
Now only master commits will be displayed e.g. on the main page of compare if no bounds are specified.
@Kobzol Kobzol force-pushed the try-commit-filter branch from 01eaad3 to b15355a Compare October 2, 2022 07:48
@Mark-Simulacrum Mark-Simulacrum merged commit 2b9051a into master Oct 2, 2022
@Mark-Simulacrum Mark-Simulacrum deleted the try-commit-filter branch October 2, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

try commit showing up on bootstrap dashboard
2 participants